Skip to content

Add a python script that auto generates async/sync stubs from executor defs #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsmith023 merged 5 commits into from
Apr 23, 2025
Merged

Add a python script that auto generates async/sync stubs from executor defs #1646

tsmith023 merged 5 commits into from
Apr 23, 2025

Conversation

@tsmith023
Copy link
Collaborator

@tsmith023 tsmith023 commented Apr 22, 2025 •
edited
Loading

Closes #1645

orca-security-eu[bot]
orca-security-eu bot reviewed Apr 22, 2025
View reviewed changes
Copy link

@orca-security-eu orca-security-eu bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@tsmith023 tsmith023 marked this pull request as ready for review April 22, 2025 13:52
@tsmith023 tsmith023 requested a review from dirkkul April 22, 2025 13:52
dirkkul
dirkkul reviewed Apr 22, 2025
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 91.74107% with 37 lines in your changes missing coverage. Please review.

Project coverage is 87.95%. Comparing base (eed679d) to head (41ba685).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../queries/fetch_objects_by_ids/generate/executor.py 54.54% 10 Missing ⚠️
...iate/collections/queries/bm25/generate/executor.py 70.00% 6 Missing ⚠️
...te/collections/queries/hybrid/generate/executor.py 53.84% 6 Missing ⚠️
...ollections/queries/near_image/generate/executor.py 63.63% 4 Missing ⚠️
...ollections/queries/near_media/generate/executor.py 63.63% 4 Missing ⚠️
...e/collections/queries/near_image/query/executor.py 88.23% 2 Missing ⚠️
...e/collections/queries/near_media/query/executor.py 88.23% 2 Missing ⚠️
...eaviate/collections/queries/bm25/query/executor.py 95.00% 1 Missing ⚠️
...ections/queries/fetch_objects/generate/executor.py 94.11% 1 Missing ⚠️
...viate/collections/queries/hybrid/query/executor.py 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
+ Coverage   87.82%   87.95%   +0.13%     
==========================================
  Files         219      254      +35     
  Lines       17485    17694     +209     
==========================================
+ Hits        15356    15563     +207     
- Misses       2129     2131       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsmith023 tsmith023 merged commit b2bc66d into main Apr 23, 2025
46 checks passed
@tsmith023 tsmith023 deleted the add-stubs-autogen-tool branch April 23, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orca-security-eu orca-security-eu[bot] orca-security-eu[bot] left review comments

@dirkkul dirkkul dirkkul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Autogenerate interface files

4 participants

@tsmith023 @codecov-commenter @dirkkul